Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#12032] Update mypy and mypy-zope. #12055

Merged
merged 2 commits into from
Jan 12, 2024
Merged

[#12032] Update mypy and mypy-zope. #12055

merged 2 commits into from
Jan 12, 2024

Conversation

adiroiban
Copy link
Member

Scope and purpose

Fixes #12032

Try latest mypy

@adiroiban adiroiban changed the title [#12032[ Update mypy and mypy-zope. [#12032] Update mypy and mypy-zope. Dec 18, 2023
@adiroiban
Copy link
Member Author

adiroiban commented Dec 18, 2023

After upgrading there are many mypy errors - https://github.com/twisted/twisted/actions/runs/7249683482/job/19748190355?pr=12055#step:5:287

I will not have time to fix those errors.

@adiroiban adiroiban marked this pull request as draft December 18, 2023 15:23
@adiroiban adiroiban mentioned this pull request Dec 18, 2023
@glyph
Copy link
Member

glyph commented Jan 12, 2024

I'm going to take a quick look at this

@glyph
Copy link
Member

glyph commented Jan 12, 2024

I have opened a superseding PR here #12080 which upgrades to 1.8. I made it a separate PR because it involves a lot more changes to the way we handle imports in order to remove a ton of type:ignore comments in favor of a centrally-managed list in the config file

@glyph glyph merged commit ddde576 into trunk Jan 12, 2024
21 of 23 checks passed
@glyph glyph deleted the 12032-mypy-upgrade branch January 12, 2024 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upgrade Mypy to 1.7
2 participants