Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#12052] Run more tests on 3.12. #12053

Merged
merged 2 commits into from
Dec 16, 2023
Merged

[#12052] Run more tests on 3.12. #12053

merged 2 commits into from
Dec 16, 2023

Conversation

adiroiban
Copy link
Member

Scope and purpose

Fixes #12052

Tries to get the test on trunk pass on 3.12, after the latest GitHub Actions changes

Copy link
Member

@glyph glyph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to land this ASAP since trunk is busted.

@glyph glyph merged commit b2a7a7b into trunk Dec 16, 2023
23 checks passed
@glyph glyph deleted the 12052-py3.12-macos-win branch December 16, 2023 00:25
@adiroiban
Copy link
Member Author

This fixes trunk by forcing/pinning the usage of 3.12.0 ... instead of the current 3.12.1

The tests are still failing on 3.12.1 on GitHub Actions.

I got 3.12.1 from deadshakes ppa on my Ubuntu 23.10 and I was not able to reproduce the test failures.

@glyph
Copy link
Member

glyph commented Dec 18, 2023

@adiroiban is there already an open PR for re-adding 3.12.1?

@adiroiban
Copy link
Member Author

adiroiban commented Dec 18, 2023

Yes. Waiting a review #12054

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

twisted tests failing on main on github actions with Python 3.12.1
3 participants