#12026 Suppress a deprecation warning on Python 3.12 #12028
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The three-arg form of generator.throw() was deprecated in Python 3.12. However, we're not sure if the modern one-arg form works on Python 3.8, which is still supported, so instead of changing it right now, this just suppresses the warning. Signed-off-by: Adam Williamson <awilliam@redhat.com>
|
Thanks for the pr. Is this needed? I can see that the tests from ##12027 for 3.8 are green
|
|
@glyph asked for both choices in the issue, so I provided both choices. There's an open question about exactly what happens when you pass a single arg that's an instance (not a type) on Python 3.8 - see python/cpython#96348 . |
|
Thanks Adam for the PR. I am join to close this for now, I hope we can have #12027 merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The three-arg form of generator.throw() was deprecated in Python 3.12. However, we're not sure if the modern one-arg form works on Python 3.8, which is still supported, so instead of changing it right now, this just suppresses the warning.
Scope and purpose
Fixes #12026 (use of a deprecated form of
generator.throw()causes deprecation warnings on Python 3.12). An alternative to #12027 - this one just suppresses the warning, rather than changing the call. @glyph asked me to submit both options.Contributor Checklist: (done)