#11834 Use reversed instead of creating a copy of slotData for every call to _getSlotValue

[dreid]

Scope and purpose

Fixes #11834

Contributor Checklist:

This process applies to all pull requests - no matter how small.
Have a look at our developer documentation before submitting your Pull Request.

Below is a non-exhaustive list (as a reminder):

• The title of the PR should describe the changes and starts with the associated issue number, like “#9782 Remove twisted.news. #1234 Brief description”.
• A release notes news fragment file was create in src/twisted/newsfragments/ (see: Release notes fragments docs.)
• The automated tests were updated.
• Once all checks are green, request a review by leaving a comment that contains exactly the string please review.
  Our bot will trigger the review process, by applying the pending review label
  and requesting a review from the Twisted dev team.

[dreid]

I do not understand the pypy failures. It seems unrelated but also it seems to fail consistently. I'm I couldn't find any other examples of similar failures on outstanding PRs but I only checked 3 or 4.

[exarkun]

I do not understand the pypy failures. It seems unrelated but also it seems to fail consistently. I'm I couldn't find any other examples of similar failures on outstanding PRs but I only checked 3 or 4.

The most recent trunk run has exactly these failures.

[exarkun]

I couldn't get the speedscope URL to load which I'm a bit sad about.

I also made a suggestion for a change to the news fragment.

The CI failures look pre-existing to me.

Please adjust the news fragment and then merge.

Thanks.

[dreid]

@exarkun Thank you for the review, bummer about the speedscope link. I've updated the news fragment. I do not have permissions to merge PRs.