#6607 - ckeygen should provide a default for the keyfile

[eevelweezel]

Scope and purpose

Fixes #6607

ckeygen doesn't provide a default for the key file, even though a default appears in the prompt, #6607

Contributor Checklist:

This process applies to all pull requests - no matter how small.
Have a look at our developer documentation before submitting your Pull Request.

Below is a non-exhaustive list (as a reminder):

• The title of the PR should describe the changes and starts with the associated issue number, like “#9782 Remove twisted.news. #1234 Brief description”.
• A release notes news fragment file was create in src/twisted/newsfragments/ (see: Release notes fragments docs.)
• The automated tests were updated.
• Once all checks are green, request a review by leaving a comment that contains exactly the string please review.
  Our bot will trigger the review process, by applying the pending review label
  and requesting a review from the Twisted dev team.

[eevelweezel]

needs-review

[adiroiban]

Thanks for helping with this.

I did just a quick review. Feel free to ignore it and wait for another developer to look over this.

[adiroiban]

Thanks for the update.

So I think the main things that need to change

• Don't mutate the input argument
• Allow dependency injection
• Fix the test to have the assertion called

[eevelweezel]

please review

[adiroiban]

I will try to get this reviewed next week, in exchange for your help with the other PRs :)

But if anyone else wants to review it, I am happy to have this merge with a review from another person.

needs re-review

[glyph]

Looks like all the feedback was addressed!