Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCSS: Fix Sass abs() percentage deprecation warning #39044

Closed
wants to merge 2 commits into from
Closed

SCSS: Fix Sass abs() percentage deprecation warning #39044

wants to merge 2 commits into from

Conversation

kirkbross
Copy link

@kirkbross kirkbross commented Aug 14, 2023

Description

Sass divide expects (will expect) an integer.

Motivation & Context

Minor irritant / Vite build warning.

Type of changes

Removal of a single character.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [x ] Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

Fixes #39028

@kirkbross kirkbross requested a review from a team as a code owner August 14, 2023 05:56
@XhmikosR XhmikosR changed the title anticipates sass abs() percentage deprecation SCSS: Fix Sass abs() percentage deprecation warning Aug 15, 2023
@XhmikosR XhmikosR added the css label Aug 15, 2023
@XhmikosR
Copy link
Member

@twbs/css-review I merged the Sass update which now yields the warning. We have this PR and #39030.

@louismaximepiton
Copy link
Member

louismaximepiton commented Aug 16, 2023

This PR solves the issue but it breaks the classes .row-cols-* since there isn't any percentages anymore. Closing it in favor of #39030.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dart-sass deprecation warning: Passing percentage units to the global abs() function is deprecated.
3 participants