Fix dart-sass deprecation warning

[blankse]

Description

Fix the deprecation warning with dart-sass. See #39028

Type of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Refactoring (non-breaking change)
• Breaking change (fix or feature that would change existing functionality)

Checklist

• I have read the contributing guidelines
• My code follows the code style of the project (using npm run lint)
• My change introduces changes to the documentation
• I have updated the documentation accordingly
• I have added tests to cover my changes
• All new and existing tests passed

Related issues

Fixes #39028

[MatthiasPeltzer]

hi... isn´t it more like percentage(divide(1, $count))? cause 100 gives eg. 333.33333% back.

[blankse]

hi... isn´t it more like percentage(divide(1, $count))? cause 100 gives eg. 333.33333% back.

Yes you are right. I changed it ad76686

Now the percentages are correct.

[louismaximepiton]

Looks good to me.
Thanks for the contribution!

[flyke]

So to use Bootstrap in a project including this pull request, you can either use:
npm install --save-dev twbs/bootstrap#39030/head
or:
yarn add --dev twbs/bootstrap#39030/head
(remove --save-dev or --dev if you want to add it as a dependency rather than a dev dependency)

[ankurk91]

Bootstrap v4.6 has the same issue

[XhmikosR]

@twbs/css-review we might also need to backport the fix in the rfs repo. If someone fixes the issue there, please CC me.

[julien-deramond]

LGTM!

16.6666666667%; becomes 16.66666667%; and 33.3333333333%; becomes 33.33333333%; but this precision is enough (already used in bootstrap.css in other contexts).

[julien-deramond]

Another possibility is the following tested by @louismaximepiton (https://github.com/twbs/bootstrap/compare/main-lmp-abs-warning-fix + fix in twbs/rfs) which would make it transparent even for folks using divide() in their own context/project.

[XhmikosR]

Can you please make a PR? Note that we need the RFS change made upstream when we decide which patch to land here.

…

On Thu, Aug 31, 2023, 08:51 Julien Déramond ***@***.***> wrote: Another possibility is the following tested by @louismaximepiton <https://github.com/louismaximepiton> ( https://github.com/twbs/bootstrap/compare/main-lmp-abs-warning-fix) which would make it transparent even for folks using divide() in their own context/project. — Reply to this email directly, view it on GitHub <#39030 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACVLNMS7RIJIDK2UWLJRKLXYAQ65ANCNFSM6AAAAAA3LMXJCM> . You are receiving this because you commented.Message ID: ***@***.***>

[julien-deramond]

We tried something via #39132 but fixing divide() by handling the dividend unit doesn't seem compatible with node-sass we still maintain (see #39132 (comment)).

I suggest that we merge + ship this patch. And then, if we get rid of the node-sass compatibility in v6, go with a solution based on what's in #39132.

It means that there would be nothing to do for now in twbs/rfs.

@twbs/css-review all fine with this proposal? Thoughts?

[n-rodriguez]

@julien-deramond any chance to see this patch backported in BS 4.x?

[julien-deramond]

@n-rodriguez Bootstrap 4 has been EOL since 2023-01-01, so unfortunately there won't be a patch backported to it.
I haven't tested it but if you're using Sass, there's prolly a way to override the part that generates the deprecation warning on your side.

[hashimaziz1]

Have these changes been pushed to a release and if not, is there a rough ETA on when they will be?

[coliff]

Have these changes been pushed to a release and if not, is there a rough ETA on when they will be?

Yes, this was included in v5.3.2 - https://github.com/twbs/bootstrap/releases