fix(n-result): show icons on re-render after hydration #5686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #5686 +/- ##
==========================================
- Coverage 60.89% 60.88% -0.02%
==========================================
Files 1125 1125
Lines 23824 23832 +8
Branches 6219 6219
==========================================
+ Hits 14508 14510 +2
- Misses 7718 7724 +6
Partials 1598 1598 ☔ View full report in Codecov by Sentry. |
OrbisK
approved these changes
Feb 21, 2024
|
Good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue #4718
When re-rendering
n-resulton client-side after hydration, the built-in default icons are not rendered. As mentioned in the related issue, this behaviour had already been solved on other components. The issue is around reactivity as explained in comment.This PR is based on the existant solution deb1a95.