Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NResult looses its icon when rendered the second time in Nuxt SSR #4718

Closed
ouuan opened this issue Apr 13, 2023 · 4 comments
Closed

NResult looses its icon when rendered the second time in Nuxt SSR #4718

ouuan opened this issue Apr 13, 2023 · 4 comments
Labels

Comments

@ouuan
Copy link
Contributor

ouuan commented Apr 13, 2023

TuSimple/naive-ui version (版本)

2.34.3

Vue version (Vue 版本)

3.2.47

Browser and its version (浏览器及其版本)

Mozilla Firefox 111.0.1 & Google Chrome 112.0.5615.49

System and its version (系统及其版本)

Arch Linux x86_64

Node version (Node 版本)

v18.15.0

Reappearance link (重现链接)

https://github.com/ouuan/naive-ui-ssr-icon-reproduction

Reappearance steps (重现步骤)

Click the "update" button twice.

Expected results (期望的结果)

The icons are always visible.

Actual results (实际的结果)

The icons disappear after several clicks.

Remarks (补充说明)

I have tried @huntersofbook/naive-ui-nuxt, https://www.naiveui.com/zh-CN/os-theme/docs/ssr and without SSR configuration. The issue is reproducible in all of them. But it's not reproducible if ssr: false.

Seems related to #2721.

@github-actions github-actions bot added the untriaged need to sort label Apr 13, 2023
@ouuan ouuan changed the title Result looses its icon when rendered the second time in Nuxt SSR NResult looses its icon when rendered the second time in Nuxt SSR May 17, 2023
@jahnli jahnli added nuxt and removed untriaged need to sort labels Dec 29, 2023
@jahnli
Copy link
Collaborator

jahnli commented Mar 12, 2024

This issue does not have any recent activity. If you are still experiencing similar problems, open a new error, including a minimal copy of the problem

@jahnli jahnli closed this as completed Mar 12, 2024
@ouuan
Copy link
Contributor Author

ouuan commented Mar 12, 2024

I not only have provided a minimal production, but also updated it last month. There is no recent activity on your side, not my side.

@jahnli
Copy link
Collaborator

jahnli commented Mar 12, 2024

#5686 has been merged

我不仅提供了最低限度的制作,而且还在上个月进行了更新。你这边最近没有活动,我这边没有。

@ouuan
Copy link
Contributor Author

ouuan commented Mar 12, 2024

Fine. I didn't notice that PR, and your comment is somewhat misleading. I suggest that you can say "fixed in #5686" instead of "does not have any recent activity".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants