fix(form-item): feedback may hide and show again, closes #5583

tusen-ai · Jan 23, 2024 · a604c4b · a604c4b
1 parent efed8c0
commit a604c4b
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/CHANGELOG.en-US.md b/CHANGELOG.en-US.md
@@ -8,6 +8,7 @@
 - Fix `n-scrollbar`'s typo on `aria-hidden` attribute.
 - `n-drawer` adds `borderRadius` attribute
 - Fix overflow issue with `n-menu` `root-indent` `indent`, closes (#5616)
+- Fix `n-form-item`'s feedback may hide and show again, closes [#5583](https://github.com/tusen-ai/naive-ui/issues/5583).
 
 ### Features
 

diff --git a/CHANGELOG.zh-CN.md b/CHANGELOG.zh-CN.md
@@ -7,7 +7,8 @@
 - 修复 `n-tree` 的 `override-default-node-click-behavior` 属性可能覆盖掉默认展开按钮和选中按钮的行为
 - Fix `n-scrollbar`'s typo on `aria-hidden` attribute.
 - `n-drawer` 新增 `borderRadius` 属性
-- 修复 `n-menu` `root-indent` `indent` 下内容溢出的问题，关闭(#5616)
+- 修复 `n-menu` `root-indent` `indent` 下内容溢出的问题，关闭 #5616
+- 修复 `n-form-item` 校验结果可能会闪烁的问题，关闭 [#5583](https://github.com/tusen-ai/naive-ui/issues/5583)
 
 ### Features
 

diff --git a/src/form/src/FormItem.tsx b/src/form/src/FormItem.tsx
@@ -386,7 +386,11 @@ export default defineComponent({
         }
       }
 
-      if (!validationResult.errors && !validationResult.warnings) {
+      if (
+        activeErrorRules.length + activeWarningRules.length > 0 &&
+        !validationResult.errors &&
+        !validationResult.warnings
+      ) {
         restoreValidation()
       }