Update project for Xcode 15 #5426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If I'm not wrong, I think it's already pre-installed in the default runners |
6 tasks
…g is set when a package comes with an 'enable upcoming feature' setting
pepicrft
commented
Sep 27, 2023
| @@ -130,7 +130,7 @@ final class EmbedScriptGenerator: EmbedScriptGenerating { | |||
| echo "mkdir -p ${CONFIGURATION_BUILD_DIR}/${FRAMEWORKS_FOLDER_PATH}" | |||
| mkdir -p "${CONFIGURATION_BUILD_DIR}/${FRAMEWORKS_FOLDER_PATH}" | |||
|
|
|||
| SWIFT_STDLIB_PATH="${DT_TOOLCHAIN_DIR}/usr/lib/swift/${PLATFORM_NAME}" | |||
| SWIFT_STDLIB_PATH="${TOOLCHAIN_DIR}/usr/lib/swift/${PLATFORM_NAME}" | |||
There was a problem hiding this comment.
For context, DT_TOOLCHAIN_DIR causes issues with Xcode 15.
fortmarek
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description 📝
GitHub's hosted runner has Xcode 15 already. This PR prepares the project to use Xcode 15 and updates the CI pipelines to use that version.
How to test the changes locally 🧐
Common workflows such as a build and testing should work.
Contributor checklist ✅
./fourier lint tuist --fixReviewer checklist ✅
changelog:added,changelog:fixed, orchangelog:changed, and the title is usable as a changelog entry