Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add onDestroy for proper cleanup + Update types #23

Merged
merged 2 commits into from
Aug 3, 2023

Conversation

longnguyen2004
Copy link
Contributor

Title should be self-explanatory.
Also, Svelte 4 deprecated SvelteComponentTyped, so we should keep this in mind when upgrading to Svelte 5 in the future.

Copy link
Contributor

@matteobruni matteobruni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matteobruni matteobruni merged commit 1ced3e2 into tsparticles:main Aug 3, 2023
3 checks passed
@longnguyen2004
Copy link
Contributor Author

Would you mind releasing a new version for this, to be in sync with the 2.12.0 release of the engine? I'm needing it for my current project

@matteobruni
Copy link
Contributor

Yes a new version will be released soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants