Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin chalk to a cjs compatible version #766

Merged
merged 2 commits into from
May 3, 2024
Merged

Pin chalk to a cjs compatible version #766

merged 2 commits into from
May 3, 2024

Conversation

TylerJang27
Copy link
Collaborator

@TylerJang27 TylerJang27 commented May 2, 2024

Latest chalk is an ESM module and cannot be loaded from the CommonJS script for npm-check and npm-check-pre-push. When node_modules are out of date, we get a confusing error message rather than the correct message. Pin the version in order to avoid this

Related thread

Also pins some snapshots to fix release tests.

Copy link

trunk-io bot commented May 2, 2024

⏱️ 16m total CI duration on this PR
Job Cumulative Duration Recent Runs
Windows Linter Tests 4m 🟩
CodeQL-Build 3m 🟩🟩
Linter Tests macOS 3m 🟩
Linter Tests ubuntu-latest 2m 🟩
Trunk Check runner [linux] 2m 🟩🟩
Repo Tests / Plugin Tests 1m 🟩🟩
Action Tests 35s 🟩🟩
Detect changed files 11s 🟩🟩
Aggregate Test Results 3s 🟩🟩

settingsfeedbackdocs ⋅ learn more about trunk.io

@TylerJang27 TylerJang27 marked this pull request as ready for review May 3, 2024 17:40
@TylerJang27 TylerJang27 merged commit 25f346b into main May 3, 2024
14 checks passed
@TylerJang27 TylerJang27 deleted the tyler/pin-chalk branch May 3, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants