Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge bazel filetypes and update to include MODULE.bazel #741

Merged
merged 7 commits into from
May 30, 2024

Conversation

dapirian
Copy link
Contributor

No description provided.

@dapirian dapirian requested a review from det April 11, 2024 22:09
Copy link

trunk-io bot commented Apr 11, 2024

⏱️ 6m total CI duration on this PR

Job Cumulative Duration Recent Runs
CodeQL-Build 6m 🟩🟩🟩🟩🟩
Aggregate Test Results 2s 🟩

settingsfeedbackdocs ⋅ learn more about trunk.io

Copy link
Collaborator

@TylerJang27 TylerJang27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do you know if there was a historical reason why we separated them out?

@dapirian
Copy link
Contributor Author

LGTM. Do you know if there was a historical reason why we separated them out?

Pedanticness. I ended up leaving the separation for backwards compat but used the inherits feature to consolidate them forward-looking.

yada.pyi Outdated Show resolved Hide resolved
Copy link

trunk-staging-io bot commented May 30, 2024

💊 0 quarantined ✅ 178 passed 🕐 123 new ⋅ (learn more)

docs ⋅ learn more about trunk.io

@TylerJang27 TylerJang27 merged commit cd0c5b3 into main May 30, 2024
15 checks passed
@TylerJang27 TylerJang27 deleted the merge_and_update_bazel_types branch May 30, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants