Skip to content

Commit

Permalink
Fix parsers for non-utf8 filepaths (#494)
Browse files Browse the repository at this point in the history
On Windows, we were crashing because our custom parsers were outputting
incorrect non-utf8 filepaths with bad encoding. It's unclear why this
was only happening on Windows, but this fix helps for all of our linters
with custom parsers.

We will also improve our discard logic to not crash when we get a bad
path like that.
  • Loading branch information
TylerJang27 committed Sep 29, 2023
1 parent 3f4fb06 commit f8fecad
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions runtimes/python/plugin.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,8 @@ runtimes:
- name: https_proxy
value: ${env.https_proxy}
optional: true
- name: PYTHONUTF8 # Necessary for isort and our custom parsers on Windows
value: 1
linter_environment:
- name: PATH
list:
Expand Down

0 comments on commit f8fecad

Please sign in to comment.