Skip to content

Commit

Permalink
Migrate over default lint ignores, environments (#225)
Browse files Browse the repository at this point in the history
Migrates these over, which gives us greater flexibility with security
linters, among other things. This PR will be a no-op until the next
release of the CLI, since these are not yet merged from sourced plugins.

In total, handles the following:
- Adds default lint ignores
- Adds default environment(s)
- Removes `trunk-cache-prune` definition (will be internal still)
- Fixes a small bug where the change set of this PR was triggering all
latest linter tests to run
  • Loading branch information
TylerJang27 committed Mar 24, 2023
1 parent 4d43a5a commit a72fb36
Show file tree
Hide file tree
Showing 7 changed files with 735 additions and 9 deletions.
4 changes: 3 additions & 1 deletion .github/workflows/pr.yaml
Expand Up @@ -115,7 +115,9 @@ jobs:

- name: Linter Tests Latest
# Run tests on Latest with any modified linters (see filters.yaml). Don't run when cancelled.
if: (failure() || success()) && needs.detect_changes.outputs.linters == 'true'
if:
(failure() || success()) && needs.detect_changes.outputs.linters == 'true' &&
needs.detect_changes.outputs.linters-files != ''
uses: ./.github/actions/linter_tests
with:
linter-version: Latest
Expand Down
8 changes: 0 additions & 8 deletions actions/trunk/plugin.yaml
Expand Up @@ -9,14 +9,6 @@ actions:
- git_hooks: [post-checkout, post-merge, pre-rebase]
notify_on_error: false

- id: trunk-cache-prune
display_name: Trunk Cache Prune
description: Periodically prune cached trunk files that are no longer needed
triggers:
- schedule: 24h
run: trunk cache prune
notify_on_error: false

- id: trunk-fmt-pre-commit
description: Run 'trunk fmt' whenever you run 'git commit'
display_name: Trunk Fmt Pre-Commit Hook
Expand Down

0 comments on commit a72fb36

Please sign in to comment.