Skip to content

Commit

Permalink
Simplify trunk-check-pre-push-always (#672)
Browse files Browse the repository at this point in the history
Change `trunk-check-pre-push-always` to not use the wrapper script. With
interactivity detection changes, we no longer need the wrapper.

This will fix the user who ran into the issue where there was a
different `trunk` in the PATH. This does not require a version
requirement update because the fix has been out since November.
  • Loading branch information
TylerJang27 committed Mar 1, 2024
1 parent d67e91e commit 9fd55bd
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 33 deletions.
2 changes: 1 addition & 1 deletion actions/trunk/plugin.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ actions:
- id: trunk-check-pre-push-always
display_name: Trunk Check Pre-Push Hook (Always)
description: Always run 'trunk check' whenever you run 'git push'
run: bash "${cwd}/trunk-check-pre-push.sh" -n --commit-ref-from-pre-push '${hook_stdin_path}'
run: trunk check -n -t git-push --commit-ref-from-pre-push '${hook_stdin_path}'
interactive: optional
triggers:
- git_hooks: [pre-push]
Expand Down
32 changes: 0 additions & 32 deletions actions/trunk/trunk-check-pre-push.sh

This file was deleted.

0 comments on commit 9fd55bd

Please sign in to comment.