Skip to content

Commit

Permalink
Fix osv-scanner and golangci-lint tests (#770)
Browse files Browse the repository at this point in the history
- `golangci-lint` released a [new
version](https://github.com/golangci/golangci-lint/releases/tag/v1.58.0)
which produces DeprecationError diagnostics for deprecated checkers.
I've updated the config and snapshots to remove them.
- This may also bring us closer to running `golangci-lint` tests on
Windows
- Updates the `osv-scanner` fuzzy matcher test with more up to date
issues. We were at the 99/100 mark.

This will make `main` green again but some release tests will still fail
until next release.
  • Loading branch information
TylerJang27 committed May 6, 2024
1 parent 25f346b commit 887931c
Show file tree
Hide file tree
Showing 3 changed files with 484 additions and 379 deletions.
4 changes: 0 additions & 4 deletions linters/golangci-lint/test_data/.golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ linters:
- govet
- asciicheck
- bodyclose
- deadcode
- depguard
- dogsled
- errcheck
Expand All @@ -25,12 +24,9 @@ linters:
- nakedret
- nolintlint
- rowserrcheck
- scopelint
- staticcheck
- structcheck
- stylecheck
- typecheck
- unconvert
- unused
- varcheck
- whitespace
Original file line number Diff line number Diff line change
Expand Up @@ -41,15 +41,15 @@ exports[`Testing linter golangci-lint test all 1`] = `
"targetType": "go",
},
{
"code": "deadcode",
"code": "unused",
"column": "6",
"file": "test_data/unused_func.go",
"issueClass": "ISSUE_CLASS_EXISTING",
"issueUrl": "https://golangci-lint.run/usage/linters/",
"level": "LEVEL_HIGH",
"line": "5",
"linter": "golangci-lint",
"message": "\`helper\` is unused",
"message": "func \`helper\` is unused",
"targetType": "go",
},
{
Expand Down

0 comments on commit 887931c

Please sign in to comment.