Fix clang-tidy issue URLs (#529)

We don't have a good way to transform issue URLs for the specific subset that are broken, so just redirect all to the list view. Fixes #518
trunk-io · Oct 17, 2023 · 246079d · 246079d
1 parent cabbee1
commit 246079d
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/linters/clang-tidy/plugin.yaml b/linters/clang-tidy/plugin.yaml
@@ -50,7 +50,7 @@ lint:
       environment:
         - name: PATH
           list: ["${linter}/bin"]
-      issue_url_format: https://clang.llvm.org/extra/clang-tidy/checks/{}.html
+      issue_url_format: https://clang.llvm.org/extra/clang-tidy/checks/list.html
       known_good_version: 16.0.3
       version_command:
         parse_regex: ${semver}

diff --git a/linters/clang-tidy/test_data/clang_tidy_v16.0.3_default_config.check.shot b/linters/clang-tidy/test_data/clang_tidy_v16.0.3_default_config.check.shot
@@ -18,7 +18,7 @@ exports[`Testing linter clang-tidy test default_config 1`] = `
       "code": "readability-convert-member-functions-to-static",
       "column": "15",
       "file": "test.hh",
-      "issueUrl": "https://clang.llvm.org/extra/clang-tidy/checks/readability-convert-member-functions-to-static.html",
+      "issueUrl": "https://clang.llvm.org/extra/clang-tidy/checks/list.html",
       "level": "LEVEL_MEDIUM",
       "line": "2",
       "linter": "clang-tidy",

diff --git a/linters/clang-tidy/test_data/clang_tidy_v16.0.3_test_config.check.shot b/linters/clang-tidy/test_data/clang_tidy_v16.0.3_test_config.check.shot
@@ -19,7 +19,7 @@ exports[`Testing linter clang-tidy test test_config 1`] = `
       "code": "readability-identifier-naming",
       "column": "30",
       "file": "basic.cc",
-      "issueUrl": "https://clang.llvm.org/extra/clang-tidy/checks/readability-identifier-naming.html",
+      "issueUrl": "https://clang.llvm.org/extra/clang-tidy/checks/list.html",
       "level": "LEVEL_MEDIUM",
       "line": "1",
       "linter": "clang-tidy",
@@ -42,7 +42,7 @@ exports[`Testing linter clang-tidy test test_config 1`] = `
       "code": "readability-identifier-naming",
       "column": "7",
       "file": "invalid_case_style.hh",
-      "issueUrl": "https://clang.llvm.org/extra/clang-tidy/checks/readability-identifier-naming.html",
+      "issueUrl": "https://clang.llvm.org/extra/clang-tidy/checks/list.html",
       "level": "LEVEL_MEDIUM",
       "line": "3",
       "linter": "clang-tidy",
@@ -64,7 +64,7 @@ exports[`Testing linter clang-tidy test test_config 1`] = `
       "code": "readability-convert-member-functions-to-static",
       "column": "15",
       "file": "test.hh",
-      "issueUrl": "https://clang.llvm.org/extra/clang-tidy/checks/readability-convert-member-functions-to-static.html",
+      "issueUrl": "https://clang.llvm.org/extra/clang-tidy/checks/list.html",
       "level": "LEVEL_MEDIUM",
       "line": "2",
       "linter": "clang-tidy",