feat(treafik): BREAKING CHANGE bump to v3 #21665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stavros-k
commented
May 6, 2024
| @@ -26,8 +26,6 @@ spec: | |||
| server: "" | |||
| forceSTSHeader: true | |||
| referrerPolicy: same-origin | |||
| sslForceHost: true | |||
| sslRedirect: true | |||
There was a problem hiding this comment.
stavros-k
commented
May 6, 2024
| @@ -26,8 +26,6 @@ spec: | |||
| server: "" | |||
| forceSTSHeader: true | |||
| referrerPolicy: same-origin | |||
| sslForceHost: true | |||
There was a problem hiding this comment.
stavros-k
commented
May 6, 2024
| @@ -7,7 +7,7 @@ metadata: | |||
| name: {{ ternary (printf "%v-%v" $.Release.Name $middlewareData.name) $middlewareData.name $.Values.ingressClass.enabled }} | |||
| namespace: {{ $.Release.Namespace }} | |||
| spec: | |||
| ipWhiteList: | |||
There was a problem hiding this comment.
|
Note: It most likely also need to update CRDs! |
We're moving Traefik CRDs to a seperate helm-chart, this might be a good moment to start enforcing that tbh |
Agree, from traefik-config changes, this PR should cover it. |
Signed-off-by: Stavros Kois <47820033+stavros-k@users.noreply.github.com>
This middleware is deprecated, please use the IPAllowList middleware instead. **Description** <!-- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. --> ⚒️ Fixes # <!--(issue)--> **⚙️ Type of change** - [ ] ⚙️ Feature/App addition - [x] 🪛 Bugfix - [ ]⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] 🔃 Refactor of current code **🧪 How Has This Been Tested?** <!-- Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration --> **📃 Notes:** <!-- Please enter any other relevant information here --> **✔️ Checklist:** - [x] ⚖️ My code follows the style guidelines of this project - [x] 👀 I have performed a self-review of my own code - [ ] #️⃣ I have commented my code, particularly in hard-to-understand areas - [ ] 📄 I have made corresponding changes to the documentation - [ ]⚠️ My changes generate no new warnings - [ ] 🧪 I have added tests to this description that prove my fix is effective or that my feature works - [x] ⬆️ I increased versions for any altered app according to semantic versioning - [x] I made sure the title starts with `feat(chart-name):`, `fix(chart-name):` or `chore(chart-name):` **➕ App addition** If this PR is an app addition please make sure you have done the following. - [ ] 🖼️ I have added an icon in the Chart's root directory called `icon.png` --- _Please don't blindly check all the boxes. Read them and only check those that apply. Those checkboxes are there for the reviewer to see what is this all about and the status of this PR with a quick glance._ --------- Signed-off-by: Mr Khachaturov <105451445+mrkhachaturov@users.noreply.github.com> Signed-off-by: Kjeld Schouten <kjeld@schouten-lebbing.nl> Co-authored-by: Kjeld Schouten <kjeld@schouten-lebbing.nl>
Ornias1993
approved these changes
May 30, 2024
Signed-off-by: Kjeld Schouten <kjeld@schouten-lebbing.nl>
Ornias1993
changed the title
Signed-off-by: Kjeld Schouten <kjeld@schouten-lebbing.nl>
Ornias1993
requested review from
alfi0812,
kqmaverick,
Heavybullets8,
bakayukii and
a team
as code owners
|
@stavros-k We can safely merge this now as it only affects a handfull of helm users |
📝 Linting results:✖️ Linting [charts/premium/traefik]: Failed - Took 1 seconds ❌ Linting: Failed - Took 1 seconds |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
⚒️ Fixes #
⚙️ Type of change
🧪 How Has This Been Tested?
📃 Notes:
✔️ Checklist:
feat(chart-name):,fix(chart-name):orchore(chart-name):➕ App addition
If this PR is an app addition please make sure you have done the following.
icon.pngPlease don't blindly check all the boxes. Read them and only check those that apply.
Those checkboxes are there for the reviewer to see what is this all about and
the status of this PR with a quick glance.