Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(whisper-asr-webservice): switch readiness and startup probe to tcp, update app version #21439

Conversation

v3DJG6GL
Copy link
Contributor

@v3DJG6GL v3DJG6GL commented Apr 28, 2024

Description

⚒️ Fixes #

⚙️ Type of change
This PR fixes a problem with readiness and startup probes: changing the liveness probe to tcp in #20042 was obviously not enough to prevent the app from always killing.
Also, I updated the app version. Something with the automatic updates doesn't seem to work with this app.

  • ⚙️ Feature/App addition
  • 🪛 Bugfix
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🔃 Refactor of current code

🧪 How Has This Been Tested?

📃 Notes:

✔️ Checklist:

  • ⚖️ My code follows the style guidelines of this project
  • 👀 I have performed a self-review of my own code
  • #️⃣ I have commented my code, particularly in hard-to-understand areas
  • 📄 I have made corresponding changes to the documentation
  • ⚠️ My changes generate no new warnings
  • 🧪 I have added tests to this description that prove my fix is effective or that my feature works
  • ⬆️ I increased versions for any altered app according to semantic versioning
  • I made sure the title starts with feat(chart-name):, fix(chart-name): or chore(chart-name):

➕ App addition

If this PR is an app addition please make sure you have done the following.

  • 🖼️ I have added an icon in the Chart's root directory called icon.png

Please don't blindly check all the boxes. Read them and only check those that apply.
Those checkboxes are there for the reviewer to see what is this all about and
the status of this PR with a quick glance.

Signed-off-by: v3DJG6GL <72495210+v3DJG6GL@users.noreply.github.com>
Signed-off-by: v3DJG6GL <72495210+v3DJG6GL@users.noreply.github.com>
@v3DJG6GL v3DJG6GL requested review from Ornias1993 and a team as code owners April 28, 2024 12:45
@Ornias1993
Copy link
Member

"Something with the automatic updates doesn't seem to work with this app."

Please do not do things like that, if automatic updates aren't being applied this is a choice by us.

@Ornias1993 Ornias1993 closed this Apr 30, 2024
@Ornias1993 Ornias1993 reopened this Apr 30, 2024
StevenMcElligott and others added 2 commits May 5, 2024 19:38
Signed-off-by: StevenMcElligott <89483932+StevenMcElligott@users.noreply.github.com>
Signed-off-by: Kjeld Schouten <kjeld@schouten-lebbing.nl>
@Ornias1993 Ornias1993 merged commit 5806933 into truecharts:master May 30, 2024
3 checks passed
@Ornias1993
Copy link
Member

@all-contributors please add @v3DJG6GL for code

Copy link
Contributor

@Ornias1993

@v3DJG6GL already contributed before to code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants