Upload existing world guide Documentation #19776

LordCrash101 · 2024-03-25T18:08:04Z

As I had some difficulty with uploading my existing world files to the app, after getting some help. I thought best to write down the instructions for others to follow.

Description

⚒️ Fixes # Added documentation

⚙️ Type of change

⚙️ Feature/App addition
🪛 Bugfix
⚠️ Breaking change (fix or feature that would cause existing functionality to not work as expected)
🔃 Refactor of current code

🧪 How Has This Been Tested?

📃 Notes:
As this is only a documentation addition, I'm not sure I have more testing to add other than what I wrote are the steps I followed to get it working.

✔️ Checklist:

⚖️ My code follows the style guidelines of this project
👀 I have performed a self-review of my own code
#️⃣ I have commented my code, particularly in hard-to-understand areas
📄 I have made corresponding changes to the documentation
⚠️ My changes generate no new warnings
🧪 I have added tests to this description that prove my fix is effective or that my feature works
⬆️ I increased versions for any altered app according to semantic versioning
I made sure the title starts with feat(chart-name):, fix(chart-name): or chore(chart-name):

➕ App addition

If this PR is an app addition please make sure you have done the following.

🖼️ I have added an icon in the Chart's root directory called icon.png

Please don't blindly check all the boxes. Read them and only check those that apply.
Those checkboxes are there for the reviewer to see what is this all about and
the status of this PR with a quick glance.

As I had some difficulty with uploading my existing world files to the app, after getting some help. I thought best to write down the instruction for others to follow. Signed-off-by: LordCrash101 <164925025+LordCrash101@users.noreply.github.com>

CLAassistant · 2024-03-25T18:08:10Z

All committers have signed the CLA.

Signed-off-by: LordCrash101 <164925025+LordCrash101@users.noreply.github.com>

xstar97

the docs name needs to be changed from spaces to -

xstar97

add new lines

charts/stable/valheim/docs/Upload existing world guide.md

Co-authored-by: Xstar97TheNoob <9399967+xstar97@users.noreply.github.com> Signed-off-by: bitpushr <91350598+bitpushr@users.noreply.github.com>

LordCrash101 · 2024-03-25T23:37:32Z

sorry slightly confused, did you need me to rename the file to replace spaces with dashes? I'm fairly new to using the git, so sorry for silly comments!

bitpushr · 2024-03-26T00:01:16Z

sorry slightly confused, did you need me to rename the file to replace spaces with dashes? I'm fairly new to using the git, so sorry for silly comments!

All good. You can see the updates/changes that were made by Xstar in the commits above your comment. We're having some CI/automation issues with docs atm so these changes might not show up for a while, but should eventually flow through to the website.

Ornias1993

THis seems to be SCALE only, we don't want SCALE-only guides unless strictly labeled as such
The whole windows part is so user specific, doesn't seem like a TrueCharts thing to add either

LordCrash101 · 2024-03-26T17:55:44Z

> * THis seems to be SCALE only, we don't want SCALE-only guides unless strictly labeled as such
I admit that this is a SCALE only guide, happy to somehow mark it as such, would adding a docusarus Warning markup to the top of file stating that it is a SCALE only guide suffice?

> * The whole windows part is so user specific, doesn't seem like a TrueCharts thing to add either
It is as that is where the files for the game are held, I can have a look on Google to see if I can find the location on Linux, but as I don't have a linux system to hand, I would be unable to verify the accuracy. I can try and setup an old PC with Linux and try to verify a linux location for the files, if it helps, but I would need sometime.

Unfortunately I found next to no guides for this SCALE app as it is, I felt having something that might point others in the general direction was better than having nothing at all.

gitguardian · 2024-04-06T19:06:32Z

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request

GitGuardian id	GitGuardian status	Secret	Commit	Filename
-		Username Password	`c1c8968`	charts/incubator/slskd/values.yaml	View secret

🛠 Guidelines to remediate hardcoded secrets

Understand the implications of revoking this secret by investigating where it is used in your code.
Replace and store your secret safely. Learn here the best practices.
Revoke and rotate this secret.
If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

following these best practices for managing and storing secrets including API keys and other credentials
install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!}

Signed-off-by: bitpushr <91350598+bitpushr@users.noreply.github.com>

Ornias1993 · 2024-05-30T12:53:29Z

As SCALE Apps are deprecated now, i'm (in the end) not going to merge this.
Sorry for your wasted effort @LordCrash101

Ornias1993 · 2024-05-30T12:53:37Z

@all-contributors please add @LordCrash101 for docs

allcontributors · 2024-05-30T12:54:00Z

@Ornias1993

I've put up a pull request to add @LordCrash101! 🎉

@LordCrash101

Adds @LordCrash101 as a contributor for doc. This was requested by Ornias1993 [in this comment](#19776 (comment)) --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>

LordCrash101 requested review from Ornias1993 and a team as code owners March 25, 2024 18:08

LordCrash101 and others added 3 commits March 25, 2024 18:21

Fixed typos and improved wording

937a4b6

Signed-off-by: LordCrash101 <164925025+LordCrash101@users.noreply.github.com>

Added title

4678840

Signed-off-by: LordCrash101 <164925025+LordCrash101@users.noreply.github.com>

Merge branch 'master' into patch-1

816691d

bitpushr approved these changes Mar 25, 2024

View reviewed changes

bitpushr enabled auto-merge (squash) March 25, 2024 22:28

xstar97 suggested changes Mar 25, 2024

View reviewed changes

charts/stable/valheim/docs/Upload existing world guide.md Outdated Show resolved Hide resolved

charts/stable/valheim/docs/Upload existing world guide.md Outdated Show resolved Hide resolved

bitpushr and others added 2 commits March 26, 2024 09:33

Update charts/stable/valheim/docs/Upload existing world guide.md

282cefb

Co-authored-by: Xstar97TheNoob <9399967+xstar97@users.noreply.github.com> Signed-off-by: bitpushr <91350598+bitpushr@users.noreply.github.com>

Update charts/stable/valheim/docs/Upload existing world guide.md

571bbdd

Co-authored-by: Xstar97TheNoob <9399967+xstar97@users.noreply.github.com> Signed-off-by: bitpushr <91350598+bitpushr@users.noreply.github.com>

bitpushr closed this Mar 25, 2024

auto-merge was automatically disabled March 25, 2024 22:34
Pull request was closed

bitpushr reopened this Mar 25, 2024

bitpushr enabled auto-merge (squash) March 25, 2024 23:56

bitpushr and others added 3 commits March 26, 2024 11:52

Merge branch 'master' into patch-1

8b45928

update docs

2fe6157

fix admonitions

dfa769c

Ornias1993 requested changes Mar 26, 2024

View reviewed changes

Merge branch 'master' into patch-1

c1c8968

Update uploading_existing_world_guide.md

5cf7ed5

Signed-off-by: bitpushr <91350598+bitpushr@users.noreply.github.com>

bitpushr approved these changes Apr 6, 2024

View reviewed changes

Ornias1993 closed this May 30, 2024

auto-merge was automatically disabled May 30, 2024 12:53
Pull request was closed

allcontributors bot mentioned this pull request May 30, 2024

docs: add LordCrash101 as a contributor for doc #22637

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upload existing world guide Documentation #19776

Upload existing world guide Documentation #19776

LordCrash101 commented Mar 25, 2024 •

edited

CLAassistant commented Mar 25, 2024 •

edited

xstar97 left a comment

xstar97 left a comment

LordCrash101 commented Mar 25, 2024

bitpushr commented Mar 26, 2024 •

edited

Ornias1993 left a comment

LordCrash101 commented Mar 26, 2024 •

edited

gitguardian bot commented Apr 6, 2024 •

edited

Ornias1993 commented May 30, 2024

Ornias1993 commented May 30, 2024

allcontributors bot commented May 30, 2024

Upload existing world guide Documentation #19776

Upload existing world guide Documentation #19776

Conversation

LordCrash101 commented Mar 25, 2024 • edited

CLAassistant commented Mar 25, 2024 • edited

xstar97 left a comment

Choose a reason for hiding this comment

xstar97 left a comment

Choose a reason for hiding this comment

LordCrash101 commented Mar 25, 2024

bitpushr commented Mar 26, 2024 • edited

Ornias1993 left a comment

Choose a reason for hiding this comment

LordCrash101 commented Mar 26, 2024 • edited

gitguardian bot commented Apr 6, 2024 • edited

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Ornias1993 commented May 30, 2024

Ornias1993 commented May 30, 2024

allcontributors bot commented May 30, 2024

LordCrash101 commented Mar 25, 2024 •

edited

CLAassistant commented Mar 25, 2024 •

edited

bitpushr commented Mar 26, 2024 •

edited

LordCrash101 commented Mar 26, 2024 •

edited

gitguardian bot commented Apr 6, 2024 •

edited