Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nightly rustfmt to workflows #3333

Merged
merged 1 commit into from
May 2, 2024
Merged

Conversation

WillLillis
Copy link
Contributor

@WillLillis WillLillis commented May 1, 2024

I noticed that invoking rustfmt from within my editor works as expected, but running cargo fmt from the command line leads to the following warnings:

Warning: can't set `wrap_comments = true`, unstable features are only available in nightly channel.
Warning: can't set `format_code_in_doc_comments = true`, unstable features are only available in nightly channel.
Warning: can't set `comment_width = 100`, unstable features are only available in nightly channel.
Warning: can't set `format_macro_matchers = true`, unstable features are only available in nightly channel.
....
Warning: can't set `format_macro_matchers = true`, unstable features are only available in nightly channel.
Warning: can't set `imports_granularity = Crate`, unstable features are only available in nightly channel.
Warning: can't set `group_imports = StdExternalCrate`, unstable features are only available in nightly channel.

Running cargo +nightly fmt of course fixes this locally.

I then noticed that these same warnings appear on the CI runs, for example in the "Run make lint" step of this workflow run. I did some testing within my fork and found that adding the changes in this PR fixes the issue, but I'm also not super familiar with Github workflows so I could also be missing something.

@amaanq amaanq merged commit 3a42c27 into tree-sitter:master May 2, 2024
12 checks passed
@WillLillis WillLillis deleted the fix_fmt branch May 2, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants