Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't error out on missing/malformed tree-sitter fields when --no-bindings is passed in #3323

Merged
merged 2 commits into from
Apr 27, 2024

Conversation

amaanq
Copy link
Member

@amaanq amaanq commented Apr 27, 2024

If --no-bindings is passed in, a default tree-sitter field doesn't get inserted, which can lead to build issues only in this case

@clason
Copy link
Contributor

clason commented Apr 27, 2024

That's not quite the fix I had in mind; I wanted --no-bindings to ignore all malformed manifest files that are not necessary for generating a parser.c.

(Not that other improvements can't be made still, mind you.)

@amaanq amaanq changed the title fix: always update the tree-sitter field if it needs to be fix: don't error out on missing/malformed tree-sitter fields when --no-bindings is passed in Apr 27, 2024
@amaanq amaanq merged commit 4130888 into tree-sitter:master Apr 27, 2024
6 checks passed
@clason
Copy link
Contributor

clason commented Apr 28, 2024

Can confirm this fixes the related nvim-treesitter issues!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants