feat(cli): support NO_COLOR
#3299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@WillLillis do you mind having it check for the |
|
Sure thing! |
WillLillis
changed the title
--no-color option to test commandNO_COLOR env var in test command
|
awesome, thanks |
amaanq
reviewed
Apr 29, 2024
Co-authored-by: Amaan Qureshi <amaanq12@gmail.com> This allows users to avoid colored output when NO_COLOR is set to 1.
|
I just moved opt_color to test.rs since it makes more sense to group related functions together - otherwise looks good |
amaanq
approved these changes
Apr 30, 2024
amaanq
changed the title
NO_COLOR env var in test commandNO_COLOR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the option to disable colored text in the
testcommand's output.It seemed a bit odd to print the (colored) diff key without colors, so when the
--no-coloroption is used the diff key isn't printed, and inprint_diff()each diff variant is labeled with "correct"/"expected"/"unexpected" in the line directly above. Another option would be to just leave the diff's formatting the same across the color options.Closes #2593