Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

380 week of year fix #406

Merged

Conversation

joshuacronemeyer
Copy link
Collaborator

While I was trying to handle the non-commercial week of the year (which is where the week starts on a sunday). I realized there were scenarios where you could mix commercial date stuff with non-commercial date stuff so had to come up with a consolidated way to handle that. I came up with always converting day of week to a monday start based day of week.

This made all our other scenarios pass without so much conditional logic and seems to handle this mix/match stuff as well.

@joshuacronemeyer joshuacronemeyer linked an issue Aug 11, 2023 that may be closed by this pull request
@joshuacronemeyer joshuacronemeyer merged commit f539048 into travisjeffery:master Aug 12, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

%W is not handled properly
1 participant