Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GraalPy and test both GraalPy and Jython env identifiers #3312

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

timfel
Copy link
Contributor

@timfel timfel commented Jul 23, 2024

tox "supports" Jython, IronPython, RustPython in the sense that they can specified for an env, and they are matched and passed on to virtualenv. Not supporting GraalPy at least to this same minimal extent means we cannot run tests against virtualenv. GraalPy is included with manylinux and supported by uv, but our patch to add support to the virtualenv project cannot pass their CI unless tox at least matches the graalpy env string and passes that on via VIRTUALENV_PYTHON.

So this PR adds that minimum of support, including a parameter to a test. I couldn't find a single test checking the match for Jython, so I added that parameter as well. Afaict this puts GraalPy and Jython on the same level as RustPython and IronPython.

(relates to #3148)

@timfel timfel requested a review from gaborbernat as a code owner July 23, 2024 11:27
@gaborbernat gaborbernat merged commit 17435df into tox-dev:main Jul 23, 2024
25 checks passed
hofbi referenced this pull request in luminartech/dev-tools Aug 9, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [tox](https://togithub.com/tox-dev/tox)
([changelog](https://tox.wiki/en/latest/changelog.html)) | `==4.15.1` ->
`==4.17.1` |
[![age](https://developer.mend.io/api/mc/badges/age/pypi/tox/4.17.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/pypi/tox/4.17.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/pypi/tox/4.15.1/4.17.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/pypi/tox/4.15.1/4.17.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>tox-dev/tox (tox)</summary>

### [`v4.17.1`](https://togithub.com/tox-dev/tox/releases/tag/4.17.1)

[Compare
Source](https://togithub.com/tox-dev/tox/compare/4.17.0...4.17.1)

<!-- Release notes generated using configuration in .github/release.yml
at 4.17.1 -->

#### What's Changed

- Restore limited `<major>.<minor>` environment name support by
[@&#8203;gaborbernat](https://togithub.com/gaborbernat) in
[https://github.com/tox-dev/tox/pull/3319](https://togithub.com/tox-dev/tox/pull/3319)
- fix(tox_env.python): do not process absolute paths to interpreter as
PythonSpec by [@&#8203;paveldikov](https://togithub.com/paveldikov) in
[https://github.com/tox-dev/tox/pull/3311](https://togithub.com/tox-dev/tox/pull/3311)

#### New Contributors

- [@&#8203;paveldikov](https://togithub.com/paveldikov) made their first
contribution in
[https://github.com/tox-dev/tox/pull/3311](https://togithub.com/tox-dev/tox/pull/3311)

**Full Changelog**:
tox-dev/tox@4.17.0...4.17.1

### [`v4.17.0`](https://togithub.com/tox-dev/tox/releases/tag/4.17.0)

[Compare
Source](https://togithub.com/tox-dev/tox/compare/4.16.0...4.17.0)

<!-- Release notes generated using configuration in .github/release.yml
at 4.17.0 -->

#### What's Changed

- Fix user guide system overview so nodes don't overlap. by
[@&#8203;Tom01098](https://togithub.com/Tom01098) in
[https://github.com/tox-dev/tox/pull/3307](https://togithub.com/tox-dev/tox/pull/3307)
- Table with list of default env vars per OS by
[@&#8203;seyidaniels](https://togithub.com/seyidaniels) in
[https://github.com/tox-dev/tox/pull/3291](https://togithub.com/tox-dev/tox/pull/3291)
- Add GraalPy and test both GraalPy and Jython env identifiers by
[@&#8203;timfel](https://togithub.com/timfel) in
[https://github.com/tox-dev/tox/pull/3312](https://togithub.com/tox-dev/tox/pull/3312)
- Add on platform constat to core by
[@&#8203;gaborbernat](https://togithub.com/gaborbernat) in
[https://github.com/tox-dev/tox/pull/3315](https://togithub.com/tox-dev/tox/pull/3315)

#### New Contributors

- [@&#8203;Tom01098](https://togithub.com/Tom01098) made their first
contribution in
[https://github.com/tox-dev/tox/pull/3307](https://togithub.com/tox-dev/tox/pull/3307)
- [@&#8203;timfel](https://togithub.com/timfel) made their first
contribution in
[https://github.com/tox-dev/tox/pull/3312](https://togithub.com/tox-dev/tox/pull/3312)

**Full Changelog**:
tox-dev/tox@4.16.0...4.17.0

### [`v4.16.0`](https://togithub.com/tox-dev/tox/releases/tag/4.16.0)

[Compare
Source](https://togithub.com/tox-dev/tox/compare/4.15.1...4.16.0)

<!-- Release notes generated using configuration in .github/release.yml
at 4.16.0 -->

#### What's Changed

- Fix two small documentation issues by
[@&#8203;srenfo](https://togithub.com/srenfo) in
[https://github.com/tox-dev/tox/pull/3297](https://togithub.com/tox-dev/tox/pull/3297)
- Fix tests after new setuptools by
[@&#8203;gaborbernat](https://togithub.com/gaborbernat) in
[https://github.com/tox-dev/tox/pull/3299](https://togithub.com/tox-dev/tox/pull/3299)
- Add `windir` to the default list of `pass_env` variables on Windows by
[@&#8203;kurtmckee](https://togithub.com/kurtmckee) in
[https://github.com/tox-dev/tox/pull/3303](https://togithub.com/tox-dev/tox/pull/3303)

#### New Contributors

- [@&#8203;srenfo](https://togithub.com/srenfo) made their first
contribution in
[https://github.com/tox-dev/tox/pull/3297](https://togithub.com/tox-dev/tox/pull/3297)

**Full Changelog**:
tox-dev/tox@4.15.1...4.16.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 4am on the first day of the
month" (UTC), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View the
[repository job
log](https://developer.mend.io/github/luminartech/dev-tools).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yMC4xIiwidXBkYXRlZEluVmVyIjoiMzguMjAuMSIsInRhcmdldEJyYW5jaCI6Im1hc3RlciIsImxhYmVscyI6W119-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
naa0yama referenced this pull request in naa0yama/PythonBoilerplate Aug 22, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [tox](https://togithub.com/tox-dev/tox)
([changelog](https://tox.wiki/en/latest/changelog.html)) | `~4.16.0` ->
`~4.18.0` |
[![age](https://developer.mend.io/api/mc/badges/age/pypi/tox/4.18.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/pypi/tox/4.18.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/pypi/tox/4.16.0/4.18.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/pypi/tox/4.16.0/4.18.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>tox-dev/tox (tox)</summary>

### [`v4.18.0`](https://togithub.com/tox-dev/tox/releases/tag/4.18.0)

[Compare
Source](https://togithub.com/tox-dev/tox/compare/4.17.1...4.18.0)

<!-- Release notes generated using configuration in .github/release.yml
at 4.18.0 -->

#### What's Changed

- Fix [#&#8203;3278](https://togithub.com/tox-dev/tox/issues/3278) -
Boost temporary directories cleanup in tests by
[@&#8203;ziima](https://togithub.com/ziima) in
[https://github.com/tox-dev/tox/pull/3323](https://togithub.com/tox-dev/tox/pull/3323)
- Fix absolute base python paths conflicting by
[@&#8203;gaborbernat](https://togithub.com/gaborbernat) in
[https://github.com/tox-dev/tox/pull/3325](https://togithub.com/tox-dev/tox/pull/3325)
- Fix [#&#8203;3318](https://togithub.com/tox-dev/tox/issues/3318) -
Suppress spinner in parallel runs in CI by
[@&#8203;ziima](https://togithub.com/ziima) in
[https://github.com/tox-dev/tox/pull/3321](https://togithub.com/tox-dev/tox/pull/3321)

**Full Changelog**:
tox-dev/tox@4.17.1...4.18.0

### [`v4.17.1`](https://togithub.com/tox-dev/tox/releases/tag/4.17.1)

[Compare
Source](https://togithub.com/tox-dev/tox/compare/4.17.0...4.17.1)

<!-- Release notes generated using configuration in .github/release.yml
at 4.17.1 -->

##### What's Changed

- Restore limited `<major>.<minor>` environment name support by
[@&#8203;gaborbernat](https://togithub.com/gaborbernat) in
[https://github.com/tox-dev/tox/pull/3319](https://togithub.com/tox-dev/tox/pull/3319)
- fix(tox_env.python): do not process absolute paths to interpreter as
PythonSpec by [@&#8203;paveldikov](https://togithub.com/paveldikov) in
[https://github.com/tox-dev/tox/pull/3311](https://togithub.com/tox-dev/tox/pull/3311)

##### New Contributors

- [@&#8203;paveldikov](https://togithub.com/paveldikov) made their first
contribution in
[https://github.com/tox-dev/tox/pull/3311](https://togithub.com/tox-dev/tox/pull/3311)

**Full Changelog**:
tox-dev/tox@4.17.0...4.17.1

### [`v4.17.0`](https://togithub.com/tox-dev/tox/releases/tag/4.17.0)

[Compare
Source](https://togithub.com/tox-dev/tox/compare/4.16.0...4.17.0)

<!-- Release notes generated using configuration in .github/release.yml
at 4.17.0 -->

##### What's Changed

- Fix user guide system overview so nodes don't overlap. by
[@&#8203;Tom01098](https://togithub.com/Tom01098) in
[https://github.com/tox-dev/tox/pull/3307](https://togithub.com/tox-dev/tox/pull/3307)
- Table with list of default env vars per OS by
[@&#8203;seyidaniels](https://togithub.com/seyidaniels) in
[https://github.com/tox-dev/tox/pull/3291](https://togithub.com/tox-dev/tox/pull/3291)
- Add GraalPy and test both GraalPy and Jython env identifiers by
[@&#8203;timfel](https://togithub.com/timfel) in
[https://github.com/tox-dev/tox/pull/3312](https://togithub.com/tox-dev/tox/pull/3312)
- Add on platform constat to core by
[@&#8203;gaborbernat](https://togithub.com/gaborbernat) in
[https://github.com/tox-dev/tox/pull/3315](https://togithub.com/tox-dev/tox/pull/3315)

##### New Contributors

- [@&#8203;Tom01098](https://togithub.com/Tom01098) made their first
contribution in
[https://github.com/tox-dev/tox/pull/3307](https://togithub.com/tox-dev/tox/pull/3307)
- [@&#8203;timfel](https://togithub.com/timfel) made their first
contribution in
[https://github.com/tox-dev/tox/pull/3312](https://togithub.com/tox-dev/tox/pull/3312)

**Full Changelog**:
tox-dev/tox@4.16.0...4.17.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View the
[repository job
log](https://developer.mend.io/github/naa0yama/PythonBoilerplate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM4LjI2LjEiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbImRhdGFzb3VyY2U6cHlwaSIsImRlcFR5cGU6ZGV2IiwibWFuYWdlcjpwb2V0cnkiLCJyZW5vdmF0ZSIsInVwZGF0ZS1taW5vciIsInZlcnNpb25pbmc6cG9ldHJ5Il19-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants