Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX TypeError: unhashable type #319

Merged
merged 12 commits into from Jan 27, 2023
Merged

Conversation

spacemanspiff2007
Copy link
Contributor

Attempt to fix #318.
The access to _TYPES_DICT should be wrapped so the error for unhashable type is captured.
This is just a quick hack that fixes the issue for me and there sure is a more elegant way of doing it ...

@spacemanspiff2007
Copy link
Contributor Author

spacemanspiff2007 commented Jan 26, 2023

pre-commit (pyupgrade) automatically changed
grafik
which is imho incompatible with python < 3.10.
Is this the intended behavior?
Test fails related because Optional is then unused

Copy link
Member

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It needs to have a unit test and run pre-commit for stylistic fixes. Also add changelog entry.

@spacemanspiff2007
Copy link
Contributor Author

It needs to have a unit test

I am just copying things together so some help would be appreciated.

run pre-commit for stylistic fixes

See my question above.

src/sphinx_autodoc_typehints/__init__.py Outdated Show resolved Hide resolved
src/sphinx_autodoc_typehints/__init__.py Outdated Show resolved Hide resolved
@hoodmane
Copy link
Collaborator

It needs to have a unit test

I am just copying things together so some help would be appreciated.

Tests look good to me.

CHANGELOG.md Outdated Show resolved Hide resolved
@hoodmane
Copy link
Collaborator

Thanks @spacemanspiff2007!

@spacemanspiff2007
Copy link
Contributor Author

Do you have any idea when the next version will be released?

@hoodmane
Copy link
Collaborator

Do you have any idea when the next version will be released?

Probably in the next day or two.

@hoodmane hoodmane changed the title fix unhashable type FIX TypeError: unhashable type Jan 27, 2023
@hoodmane hoodmane merged commit d181c2d into tox-dev:main Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Event 'autodoc-process-docstring' threw an exception (exception: unhashable type: 'ParamSpecArgs')
3 participants