ENH Add a css wrapper to generated types #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoodmane
commented
Nov 8, 2023
| @@ -209,7 +210,7 @@ def format_annotation(annotation: Any, config: Config) -> str: # noqa: C901, PL | |||
| fully_qualified: bool = getattr(config, "typehints_fully_qualified", False) | |||
| prefix = "" if fully_qualified or full_name == class_name else "~" | |||
| role = "data" if module == "typing" and class_name in _PYDATA_ANNOTATIONS else "class" | |||
| args_format = "\\[{}]" | |||
| args_format = "\\ \\[{}]" | |||
There was a problem hiding this comment.
Maybe it would be better to use r here and in lots of other places: r"\ \[{}]" would have half as many slashes...
Resolves issue tox-dev#395
|
I didn't know you could create a role like that, that's nice to know :) |
|
@hoodmane for some reason this broke tox documentation on TypeVar: 
https://github.com/tox-dev/tox/actions/runs/6822355429/job/18554265718 Any idea why is that? |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue #395.
Here's a screenshot where I've used this in Pyodide's docs to add some ugly css to the types: