Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeVar broke with 1.25 #398

Closed
gaborbernat opened this issue Nov 10, 2023 · 3 comments · Fixed by #399
Closed

TypeVar broke with 1.25 #398

gaborbernat opened this issue Nov 10, 2023 · 3 comments · Fixed by #399
Assignees
@hoodmane

Comments

@gaborbernat
Copy link
Member

gaborbernat commented Nov 10, 2023 •
edited

@hoodmane for some reason #397 broke tox documentation on TypeVar

image

https://github.com/tox-dev/tox/actions/runs/6822355429/job/18554265718

Any idea why is that?

Originally posted by @gaborbernat in #397 (comment)
@hoodmane
Copy link
Collaborator

I'll look into it. I guess the first step is to add a test case for this...

@hoodmane
Copy link
Collaborator

Most likely the problem is we need an extra backslash space somewhere.

@gaborbernat
Copy link
Member Author

Thanks ❤️

@hoodmane hoodmane mentioned this issue Nov 10, 2023
Merged
hoodmane added a commit to hoodmane/sphinx-autodoc-typehints that referenced this issue Nov 10, 2023
@hoodmane
FIX Make sure to put a slash space between xref and type args
37b5328 
Fixes tox-dev#398
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hoodmane hoodmane

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

FIX Put a slash space between xref and type args hoodmane/sphinx-autodoc-typehints
2 participants
@gaborbernat @hoodmane