Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "asyncio: Remove atexit hook" #3332

Merged
merged 2 commits into from
Oct 29, 2023
Merged

Revert "asyncio: Remove atexit hook" #3332

merged 2 commits into from
Oct 29, 2023

Commits on Oct 14, 2023

  1. Revert "asyncio: Remove atexit hook" 

    This reverts commit 6236374.

We are again seeing hangs at shutdown in
SyncHTTPClientTest.test_destructor_log. Maybe putting this back will
help.
    @bdarnell
    bdarnell committed Oct 14, 2023
    Configuration menu
    Copy the full SHA
    dbbd42e View commit details
    Browse the repository at this point in the history

  2. test: Close the thread pool in run_on_executor test 

    If this executor was left around it would be GC'd at an unpredictable
time and would often be reported as a failure in other circlerefs tests.
(For unknown reasons this would occur most often in i686 (i.e. 32-bit)
linux builds).
    @bdarnell
    bdarnell committed Oct 14, 2023
    Configuration menu
    Copy the full SHA
    3340c39 View commit details
    Browse the repository at this point in the history