Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sync: improve cancel-safety documentation for mpsc::Sender::send #5947

Merged
merged 3 commits into from Aug 25, 2023
Merged

sync: improve cancel-safety documentation for mpsc::Sender::send #5947

merged 3 commits into from Aug 25, 2023

Commits on Aug 25, 2023

  1. sync: improve cancel-safety documentation for mpsc::Sender::send 

    This specific issue (data loss because a send got cancelled) has bitten
our team a couple of times over the last few months. We've switched to
recommending this kind of reserve pattern instead.
    @sunshowers
    sunshowers committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    60508bd View commit details
    Browse the repository at this point in the history

  2. address review nit

    @sunshowers
    sunshowers committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    0b605d3 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into sender-docs

    @hawkw
    hawkw committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    7f9509f View commit details
    Browse the repository at this point in the history