Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement task dumps for current-thread runtime. #5608

Merged
merged 39 commits into from
Apr 27, 2023
Merged

Implement task dumps for current-thread runtime. #5608

merged 39 commits into from
Apr 27, 2023

Commits on Apr 12, 2023

  1. tokio: introduce Handle::dump and impl for current-thread runtime 

    Task dumps are snapshots of runtime state. Taskdumps are collected by
instrumenting Tokio's leaves to conditionally collect backtraces, which
are then coalesced per-task into execution tree traces.

This initial implementation only supports collecting taskdumps from
within the context of a current-thread runtime, and only `yield_now()`
is instrumented.
    @jswrenn
    jswrenn committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    1222dfb View commit details
    Browse the repository at this point in the history

  2. tokio: limit taskdump test to tokio_unstable & 'taskdump' feature

    @jswrenn
    jswrenn committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    d9aa093 View commit details
    Browse the repository at this point in the history

  3. tokio: limit taskdump example to 'taskdump' feature

    @jswrenn
    jswrenn committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    66cd9c9 View commit details
    Browse the repository at this point in the history

  4. tokio: don't use let-else syntax 

    ref: https://github.com/tokio-rs/tokio/pull/5608/files#r1161101426
    @jswrenn
    jswrenn committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    206b3d4 View commit details
    Browse the repository at this point in the history

  5. tokio: encapsulate taskdumping refcount shenanigans 

    ref: https://github.com/tokio-rs/tokio/pull/5608/files#r1161100780
    @jswrenn
    jswrenn committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    b998f74 View commit details
    Browse the repository at this point in the history

  6. tokio: revise taskdump imports to conform to tokio conventions 

    ref: https://github.com/tokio-rs/tokio/pull/5608/files#r1161101519
    @jswrenn
    jswrenn committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    8a727a1 View commit details
    Browse the repository at this point in the history

  7. tokio: fix formatting issue missed by rustfmt 

    ref: https://github.com/tokio-rs/tokio/pull/5608/files#r1161101463
    @jswrenn
    jswrenn committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    80dbaf7 View commit details
    Browse the repository at this point in the history

  8. tokio: limit taskdumps to linux 

    Taskdumps depend on backtrace-rs, whose unwinding behavior is
platform-dependent. Taskdumps should not be enabled on a platform
without first assessing and mitigating platform-dependent behavior.

ref: https://github.com/tokio-rs/tokio/pull/5608/files#r1162746834
    @jswrenn
    jswrenn committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    c132b33 View commit details
    Browse the repository at this point in the history

  9. tokio: remove pointless let binding

    @jswrenn
    jswrenn committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    9c86604 View commit details
    Browse the repository at this point in the history

  10. tokio: add taskdump roots to all appropriate places

    @jswrenn
    jswrenn committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    306a547 View commit details
    Browse the repository at this point in the history

  11. tokio: fix broken taskdump test

    @jswrenn
    jswrenn committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    725bf3f View commit details
    Browse the repository at this point in the history

  12. tokio: fallback taskdump example when unsupported

    @jswrenn
    jswrenn committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    c20af63 View commit details
    Browse the repository at this point in the history

  13. tokio: bump backtrace-rs version to 0.3.58 

    This version gives us `From<Frame> for BacktraceFrame`.
    @jswrenn
    jswrenn committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    52c8ca9 View commit details
    Browse the repository at this point in the history

  14. tokio: tweak dump example to avoid warnings

    @jswrenn
    jswrenn committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    fdc01e1 View commit details
    Browse the repository at this point in the history

  15. tokio: make taskdump feature depend on rt

    @jswrenn
    jswrenn committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    144f378 View commit details
    Browse the repository at this point in the history

  16. tokio: limit taskdumps to specific, blessed platforms 

    Taskdumps depend on backtrace-rs, whose unwinding behavior is
platform-dependent. Taskdumps should not be enabled on a platform
without first assessing and mitigating platform-dependent behavior.

ref: https://github.com/tokio-rs/tokio/pull/5608/files#r1162746834
    @jswrenn
    jswrenn committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    c824389 View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2023

  1. tokio: compile_error when taskdump feature is unsupported 

    Namely, when it is used without `--cfg tokio_unstable`, or when it
is used on an unsupported target.
    @jswrenn
    jswrenn committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    0c655bb View commit details
    Browse the repository at this point in the history

  2. tokio: taskdumps cargo feature -> --cfg tokio_taskump

    @jswrenn
    jswrenn committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    578c3c4 View commit details
    Browse the repository at this point in the history

  3. tokio: restrict visibility of various items 

    ref: tokio-rs#5608 (comment)
ref: tokio-rs#5608 (comment)
ref: tokio-rs#5608 (comment)
    @jswrenn
    jswrenn committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    ac7fa6b View commit details
    Browse the repository at this point in the history

  4. tokio: rustfmt

    @jswrenn
    jswrenn committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    a246b11 View commit details
    Browse the repository at this point in the history

  5. tokio: don't cross-test with --cfg tokio_taskdump 

    I don't know how to conditionally only set this cfg on supported
platforms, yet. We *should* be testing on these platforms, though.
    @jswrenn
    jswrenn committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    a62f9ee View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2023

  1. tokio: don't --cfg tokio_taskdump on unsupported platforms

    @jswrenn
    jswrenn committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    f695499 View commit details
    Browse the repository at this point in the history

  2. tokio: restrict visibility of RawTask 

    ref: tokio-rs#5608 (comment)
    @jswrenn
    jswrenn committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    bb6990f View commit details
    Browse the repository at this point in the history

  3. tokio: don't alias HashMap and HashSet 

    ref: https://github.com/tokio-rs/tokio/pull/5608/files/c8243892baac25e4ea4de918630b3d5381213ea9#r1165816578
    @jswrenn
    jswrenn committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    51d15f0 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into taskdump-backtracing

    @jswrenn
    jswrenn committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    178bf74 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2023

  1. Merge branch 'master' into taskdump-backtracing

    @jswrenn
    jswrenn committed Apr 16, 2023
    Configuration menu
    Copy the full SHA
    0a8d240 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2023

  1. tokio: tweak taskdump CI 

    Trying to fix syntax error.
    @jswrenn
    jswrenn committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    b6d093a View commit details
    Browse the repository at this point in the history

  2. tokio: fix taskdump arch cfg

    @jswrenn
    jswrenn committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    1ff355b View commit details
    Browse the repository at this point in the history

  3. tokio: --cfg tokio_taskdump requires rt feature

    @jswrenn
    jswrenn committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    9e0dd91 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into taskdump-backtracing

    @jswrenn
    jswrenn committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    9a5e7fa View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2023

  1. tokio: optimize LinkedList::for_each 

    ref: tokio-rs#5608 (comment)
    @jswrenn
    jswrenn committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    f536db5 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into taskdump-backtracing

    @jswrenn
    jswrenn committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    d3cda94 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2023

  1. tokio: compile_error liberally for unsupported taskdump platforms 

    ref: tokio-rs#5608 (comment)
    @jswrenn
    jswrenn committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    a29974d View commit details
    Browse the repository at this point in the history

  2. tokio: use clear() instead of drain(..) to drain queues 

    ref: tokio-rs#5608 (comment)
    @jswrenn
    jswrenn committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    51f970f View commit details
    Browse the repository at this point in the history

  3. ci: don't --cfg tokio_taskdump in 'build loom tests'

    @jswrenn
    jswrenn committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    8a8dceb View commit details
    Browse the repository at this point in the history

  4. ci: test unstable with and without taskdumps 

    ref: tokio-rs#5608 (comment)
    @jswrenn
    jswrenn committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    b0b1160 View commit details
    Browse the repository at this point in the history

  5. tokio: don't error on all(not(feature = "rt"), tokio_taskdump)) 

    ref: tokio-rs#5608 (comment)
    @jswrenn
    jswrenn committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    8318d93 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2023

  1. ci: test feature powerset with unstable && !taskdump cfgs 

    ref: https://github.com/tokio-rs/tokio/pull/5608/files#r1177542036
    @jswrenn
    jswrenn committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    0dc4b68 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into taskdump-backtracing

    @jswrenn
    jswrenn committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    04bd5e1 View commit details
    Browse the repository at this point in the history