Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(force_waker_pipe): swap receiver and sender fd #1722

Merged
merged 1 commit into from Oct 19, 2023

Conversation

haraldh
Copy link
Contributor

@haraldh haraldh commented Oct 19, 2023

Sender and receiver fd where swapped resulting in:

❯ RUSTFLAGS="--cfg mio_unsupported_force_waker_pipe" cargo test --test events events_all --all-features
   Compiling mio v0.8.8 (/home/harald/git/mio)
    Finished test [unoptimized + debuginfo] target(s) in 0.35s
     Running tests/events.rs (target/debug/deps/events-c745c521d9f052e3)

running 1 test
test events_all ... FAILED

failures:

---- events_all stdout ----
thread 'events_all' panicked at 'unable to wake: Os { code: 9, kind: Uncategorized, message: "Bad file descriptor" }', tests/events.rs:30:18
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

failures:
    events_all

test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 1 filtered out; finished in 0.00s

error: test failed, to rerun pass `--test events`

Fixed that and added a CI test.

Sender and receiver fd where swapped resulting in:
```
❯ RUSTFLAGS="--cfg mio_unsupported_force_waker_pipe" cargo test --test events events_all --all-features
   Compiling mio v0.8.8 (/home/harald/git/mio)
    Finished test [unoptimized + debuginfo] target(s) in 0.35s
     Running tests/events.rs (target/debug/deps/events-c745c521d9f052e3)

running 1 test
test events_all ... FAILED

failures:

---- events_all stdout ----
thread 'events_all' panicked at 'unable to wake: Os { code: 9, kind: Uncategorized, message: "Bad file descriptor" }', tests/events.rs:30:18
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

failures:
    events_all

test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 1 filtered out; finished in 0.00s

error: test failed, to rerun pass `--test events`
```

Fixed that and added a CI test.

Signed-off-by: Harald Hoyer <harald@matterlabs.dev>
@Thomasdezeeuw Thomasdezeeuw merged commit 8eb4010 into tokio-rs:master Oct 19, 2023
21 checks passed
@Thomasdezeeuw
Copy link
Collaborator

Thanks @haraldh

@haraldh haraldh deleted the fix_waker_pipe branch October 19, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants