Add AIX operating system support #1704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thomasdezeeuw
requested changes
Aug 1, 2023
src/sys/unix/waker.rs
Outdated
| syscall!(pipe2(fds.as_mut_ptr(), libc::O_NONBLOCK | libc::O_CLOEXEC))?; | ||
| #[cfg(target_os = "aix")] | ||
| syscall!(pipe(fds.as_mut_ptr()))?; |
There was a problem hiding this comment.
You still need to set the libc::O_NONBLOCK | libc::O_CLOEXEC otherwise this will not work.
AIX does not have pipe2 system call. Use pipe with fcntl instead.
src/sys/unix/waker.rs
Outdated
| @@ -265,6 +265,32 @@ mod pipe { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| #[cfg(target_os = "aix")] | |||
| fn pipe2() -> io::Result<(RawFd, RawFd)> { | |||
There was a problem hiding this comment.
Since this is essentially the same code as in src/sys/unix/pipe.rs, maybe we should reuse that code.
Thomasdezeeuw
approved these changes
Aug 8, 2023
|
|
|
@ecnelises I've opened ecnelises#1 to solve that. |
This also adds a new function sys::unix::pipe::new_raw that creates a pipe, returning the raw fds. This is used by the Waker implementation and of course sys::unix::pipe::new (which is exposed as mio::unix::pipe::new).
|
Thanks @ecnelises |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AIX does not have
epollorkqueuefunctionality, so it relies onforce_poll_pollfeature.