Add ESP-IDF framework support #1692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
6 tasks
|
Note that this will conflict with #1687 but with the latest low-churn changes it only conflicts in one trivial place that I can easily fix in either this PR or the other one depending on which one lands first. |
Thomasdezeeuw
approved these changes
Jul 24, 2023
Thomasdezeeuw
approved these changes
Jul 25, 2023
This was referenced Jul 27, 2023
Closed
|
I think this is good to be merged if you can resolve the merge conflict. Afterwards we can open an issue for official support, which would require a maintainer and CI support, etc. |
Mostly fixing compiler errors but also working around nonblocking issues with accept, eventfd, etc. Closes tokio-rs#1691
|
Ready to rock |
Thomasdezeeuw
approved these changes
Jul 31, 2023
|
Thanks @jasta |
4 tasks
|
Opened #1703 for follow ups. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly fixing compiler errors but also working around nonblocking issues with accept, eventfd, etc.
Closes #1691