Add mio_unsupported_force_waker_pipe cfg flag #1685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
typo in cfg |
|
s/unspported/unsupported |
Darksonn
approved these changes
Jun 24, 2023
Thomasdezeeuw
force-pushed
the
force-waker-pipe
branch
from
0674e24
to
f76fccd
Compare
|
one more typo in the commit message, but I don't care |
Thomasdezeeuw
force-pushed
the
force-waker-pipe
branch
from
f76fccd
to
4a4bd5e
Compare
|
I'm getting way to lazy with all the autocomplete stuff... |
This, unsupported, flag forces the Waker implementation to use the pipe implementation. This is required because some SGX runtimes like gramine do not have a secure emulation of the `eventfd` syscall, compiling with this flag will produce a more secure SGX application. See also: https://gramine.readthedocs.io/en/stable/manifest-syntax.html#allowing-eventfd Co-authored-by: Thomas de Zeeuw <thomasdezeeuw@gmail.com>
Thomasdezeeuw
changed the title
haraldh
approved these changes
Jun 25, 2023
|
Thank you! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This, unuspported, flag forces the Waker implementation to use the pipe implementation.
This is required because some SGX runtimes like gramine do not have a secure emulation of the
eventfdsyscall, compiling with this flag will produce a more secure SGX application.See also:
https://gramine.readthedocs.io/en/stable/manifest-syntax.html#allowing-eventfd
@haraldh I used your commit, but expanded it to also disable kqueue. I added myself as co-author and removed your sign off (as you didn't sign off the changes).
Fixes #1682