Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove log dependency #1666

Closed
wants to merge 3 commits into from
Closed

remove log dependency #1666

wants to merge 3 commits into from

Commits on Apr 12, 2023

  1. remove log dependency 

    Currently, Mio depends on `log`. In rust-lang/log#552, the `log`
maintainers aim to increase `log`'s MSRV to 1.60. This MSRV increase
would impact Mio, which in turn, would impact Tokio. As of 1.25, Tokio
supports Rust 1.49 with the intent of supporting it until March 2024.

Mio mostly uses the `log` dependency for debugging/tracing. Removing the
`log` dependency has minimal impact and is the easiest way to resolve
the MSRV issue. Additionally, this is another step towards minimizing
Tokio's dependencies.
    @carllerche
    carllerche committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    c98070e View commit details
    Browse the repository at this point in the history

  2. try again

    @carllerche
    carllerche committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    6c93a5d View commit details
    Browse the repository at this point in the history

  3. try to fix CI

    @carllerche
    carllerche committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    845c2ec View commit details
    Browse the repository at this point in the history