Remove TcpSocket type #1514
Merged
Remove TcpSocket type #1514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The socket2 crate provide all the functionality and more. Furthermore supporting all socket options is beyond the scope of Mio. The easier migration is to the socket2 crate, using the Socket or SockRef types. The migration for Tokio is tracked in tokio-rs/tokio#4135.
Darksonn
reviewed
Oct 7, 2021
Comment on lines
-217
to
+222
| pub const POLL_RECEIVE: u32 = 0b000_000_001; | ||
| pub const POLL_RECEIVE_EXPEDITED: u32 = 0b000_000_010; | ||
| pub const POLL_SEND: u32 = 0b000_000_100; | ||
| pub const POLL_DISCONNECT: u32 = 0b000_001_000; | ||
| pub const POLL_ABORT: u32 = 0b000_010_000; | ||
| pub const POLL_LOCAL_CLOSE: u32 = 0b000_100_000; | ||
| pub const POLL_RECEIVE: u32 = 0b0_0000_0001; | ||
| pub const POLL_RECEIVE_EXPEDITED: u32 = 0b0_0000_0010; | ||
| pub const POLL_SEND: u32 = 0b0_0000_0100; | ||
| pub const POLL_DISCONNECT: u32 = 0b0_0000_1000; | ||
| pub const POLL_ABORT: u32 = 0b0_0001_0000; | ||
| pub const POLL_LOCAL_CLOSE: u32 = 0b0_0010_0000; |
There was a problem hiding this comment.
Was this some sort of change by rustfmt?
There was a problem hiding this comment.
This was a Clippy warnings on Windows, which we don't check on the CI.
There was a problem hiding this comment.
The change doesn't bother me — it just seemed like the old grouping was intentional.
There was a problem hiding this comment.
It seems I change it to bit patterns in commit 800b786 and just miscounted or something. I don't remember any intention behind it.
Thomasdezeeuw
force-pushed
the
remove_tcp_socket
branch
from
c10f861
to
b20a86d
Compare
Seems this isn't check on the CI.
Thomasdezeeuw
force-pushed
the
remove_tcp_socket
branch
from
b20a86d
to
943cbb6
Compare
|
Ugh.. now bitflags broke the MSRV in cargo-hacks... I'll change the install of cargo-hack to use nightly or something. |
|
Related nix-rust/nix#1548 and bitflags/bitflags#255. |
Cargo-hack's (transient) dependency bitflags has updated its MSRV.
|
@Darksonn sorry for the noise but the CI is finally green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The socket2 crate provide all the functionality and more. Furthermore
supporting all socket options is beyond the scope of Mio.
The easier migration is to the socket2 crate, using the Socket or
SockRef types.
The migration for Tokio is tracked in
tokio-rs/tokio#4135.