Memory leak in owned_to_vec

[venomousmoog]

The following sequence:

    let b1 = Bytes::from_owner(owner);
    let v1: Vec<u8> = b1.into();

Would fail to drop owner (the expectation for the vtable *_to_vec is that it takes ownership of the instance, but owned_to_vec was not). Since owned_to_mut depended on owned_to_vec and was correctly dropping, the fix was to move the drop logic from owned_to_mut to owned_to_vec.

This change adds an appropriate test for ::into() for Bytes::from_owner.

[Darksonn]

Thank you.

[scottlamb]

the expectation for the vtable *_to_vec is that it takes ownership of the instance, but owned_to_vec was not

Should the to_vec and to_mut vtable entries be called into_vec and into_mut, respectively, to make this misunderstanding less likely?

I also wonder if the owned_to_vec test in test_bytes.rs is accomplishing anything, given that it's using slice::to_vec rather than a Bytes method. I suspect it was meant to exercise the behavior the new owner_into_vec test does.

[Darksonn]

Yes, that's an excellent idea. Do you want to submit a PR to rename them?

I did run the test locally before merging this, and the test failed without this fix.

[scottlamb]

Yes, that's an excellent idea. Do you want to submit a PR to rename them?

Will do.

I did run the test locally before merging this, and the test failed without this fix.

The new owned_into_vec test, right? The pfd-existing owned_to_vec above it is the one I'm referring to.