Try to clone 'main' first. #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The git-library doesn't support cloning repositories that use 'main' as default branch: go-git/go-git#363 We therefore try 'main', 'master' and 'trunk'. Until now we tried 'master' first, but since the Toit registry already uses 'main' that leads to an unnecessary clone-attempt. It also allows a race condition where another toit.pkg command could try to pull the 'master' branch.
kasperl
approved these changes
Jan 31, 2022
| @@ -343,7 +343,7 @@ func (gr *gitRegistry) Load(ctx context.Context, sync bool, cache Cache, ui UI) | |||
| url := gr.url | |||
|
|
|||
| var err error | |||
| for _, branch := range []string{"master", "main", "trunk"} { | |||
| for _, branch := range []string{"main", "master", "trunk"} { | |||
There was a problem hiding this comment.
Add a comment that explains that the order matters here.
There was a problem hiding this comment.
added a comment, but since the race-condition will disappear with the follow-up PRs, didn't explicitly say that the order matters (except for speed).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The git-library doesn't support cloning repositories that use 'main' as
default branch: go-git/go-git#363
We therefore try 'main', 'master' and 'trunk'.
Until now we tried 'master' first, but since the Toit registry already
uses 'main' that leads to an unnecessary clone-attempt. It also allows a
race condition where another toit.pkg command could try to pull the
'master' branch.