Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support ai retry #6971

Closed
wants to merge 3 commits into from
Closed

feat: support ai retry #6971

wants to merge 3 commits into from

Conversation

regischen
Copy link
Member

@regischen regischen commented May 17, 2024

Copy link

graphite-app bot commented May 17, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @regischen and the rest of your teammates on Graphite Graphite

@regischen regischen removed the request for review from pengx17 May 17, 2024 06:27
@regischen regischen changed the title feat: support ai retry feat: support chat retry May 17, 2024
Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.22%. Comparing base (4b30fbc) to head (921563e).

Current head 921563e differs from pull request most recent head 103cbe6

Please upload reports for the commit 103cbe6 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #6971      +/-   ##
==========================================
- Coverage   67.34%   67.22%   -0.13%     
==========================================
  Files         612      584      -28     
  Lines       29714    28094    -1620     
  Branches     2676     2587      -89     
==========================================
- Hits        20012    18886    -1126     
+ Misses       9427     8937     -490     
+ Partials      275      271       -4     
Flag Coverage Δ
server-test 78.09% <ø> (+0.31%) ⬆️
unittest 39.39% <ø> (+0.35%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -83,6 +85,11 @@ async function createSessionMessage({
})
);
}
if (retry)
return {
sessionId,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think in @darkskygit's retry impl, the correct way to retry a message is to send a new action with the previous message id

Copy link
Member Author

image.png

The document says retry don't need messageId

@regischen regischen changed the title feat: support chat retry feat: support ai retry May 17, 2024
@regischen regischen closed this May 28, 2024
@darkskygit darkskygit deleted the feat-add-retry branch May 28, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

2 participants