fix(overview-user-stories): fix the spotlight doesn't move on page scroll #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
CatsJuice
changed the title
|
Very nice polish, the previous impl didn't combine with scrolling so it looked weird. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
description
I found that the previous implementation using
useMouseInElementis not working due tovueuse's internal bug (this issue).Instead of using
useMouseInElementdirectly, we can useuseElementBoundinganduseMousetogether.By the way, I've removed some code that is unnecessary in this file. If there's something I haven't considered, please point it out or close this pr.
:)
compare
CleanShot.2023-07-19.at.23.45.18.mp4
CleanShot.2023-07-19.at.23.42.41.mp4