fix(snowflake): Allow alias expansion inside JOIN statements #4504
+44
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dammit, missed the formatting checks locally. I'll fix tomorrow, it's 8PM here. |
Comment on lines
+69
to
70
| dialect, | ||
| expand_only_groupby=dialect.EXPAND_ALIAS_REFS_EARLY_ONLY_IN_GROUP_BY, |
There was a problem hiding this comment.
Passing dialect here means we can refactor the expand_only_groupby flag as well.
There was a problem hiding this comment.
Doing that actually make some BigQuery tests fail, because this call line 77
if not schema.empty and expand_alias_refs:
_expand_alias_refs(scope, resolver, dialect)alwasy has expand_only_groupby=False regardless of the dialect.
There was a problem hiding this comment.
Ah, makes sense. Should we refactor this PR then to introduce a similar constant and an arg like expand_joins?
georgesittas
approved these changes
Dec 12, 2024
Co-authored-by: Jo <46752250+georgesittas@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4502