feat: cleaner IS_ASCII for TSQL (#4592)

tobymao · Jan 10, 2025 · 853cbe6 · 853cbe6
1 parent bc9975f
commit 853cbe6
Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/sqlglot/dialects/tsql.py b/sqlglot/dialects/tsql.py
@@ -1271,4 +1271,4 @@ def dpipe_sql(self, expression: exp.DPipe) -> str:
             )
 
         def isascii_sql(self, expression: exp.IsAscii) -> str:
-            return f"(PATINDEX('%[^' + CHAR(0x00) + '-' + CHAR(0x7f) + ']%' COLLATE Latin1_General_BIN, {self.sql(expression.this)}) = 0)"
+            return f"(PATINDEX(CONVERT(VARCHAR(MAX), 0x255b5e002d7f5d25) COLLATE Latin1_General_BIN, {self.sql(expression.this)}) = 0)"
diff --git a/tests/dialects/test_dialect.py b/tests/dialects/test_dialect.py
@@ -528,7 +528,7 @@ def test_is_ascii(self):
                 "sqlite": "SELECT (NOT x GLOB CAST(x'2a5b5e012d7f5d2a' AS TEXT))",
                 "mysql": "SELECT REGEXP_LIKE(x, '^[[:ascii:]]*$')",
                 "postgres": "SELECT (x ~ '^[[:ascii:]]*$')",
-                "tsql": "SELECT (PATINDEX('%[^' + CHAR(0x00) + '-' + CHAR(0x7f) + ']%' COLLATE Latin1_General_BIN, x) = 0)",
+                "tsql": "SELECT (PATINDEX(CONVERT(VARCHAR(MAX), 0x255b5e002d7f5d25) COLLATE Latin1_General_BIN, x) = 0)",
                 "oracle": "SELECT NVL(REGEXP_LIKE(x, '^[' || CHR(1) || '-' || CHR(127) || ']*$'), TRUE)",
             },
         )