Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: access more frames via direct read_frame() method #192

Merged
merged 7 commits into from
Nov 15, 2023
Merged

Conversation

tlambert03
Copy link
Owner

the file in #190 revealed a case where sometimes there are more frames available and readable than the product of the experiment axes. This PR makes those frames accessible by slightly relaxing the logic of the reader read_frame method.

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5a7eb19) 95.40% compared to head (2289046) 95.43%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #192      +/-   ##
==========================================
+ Coverage   95.40%   95.43%   +0.03%     
==========================================
  Files          17       17              
  Lines        2348     2346       -2     
==========================================
- Hits         2240     2239       -1     
+ Misses        108      107       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Nov 14, 2023

CodSpeed Performance Report

Merging #192 will improve performances by 34.97%

Comparing read_frame (2289046) with main (5a7eb19)

Summary

⚡ 1 improvements
✅ 12 untouched benchmarks

Benchmarks breakdown

Benchmark main read_frame Change
test_time_imread[jonas_control002] 200.7 ms 148.7 ms +34.97%

@tlambert03 tlambert03 mentioned this pull request Nov 15, 2023
@tlambert03 tlambert03 merged commit eb1deb2 into main Nov 15, 2023
20 checks passed
@tlambert03 tlambert03 deleted the read_frame branch November 15, 2023 12:05
@tlambert03 tlambert03 added enhancement New feature or request bug Something isn't working and removed enhancement New feature or request labels Nov 15, 2023
@tlambert03 tlambert03 changed the title feat: access more frames via direct read_frame() method fix: access more frames via direct read_frame() method Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant