Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add read_frame and loop_indices to public api #181

Merged
merged 2 commits into from
Oct 6, 2023
Merged

Conversation

tlambert03
Copy link
Owner

making read_frame and loop_indices public

@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Merging #181 (67b1aa6) into main (788590b) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #181      +/-   ##
==========================================
+ Coverage   95.32%   95.33%   +0.01%     
==========================================
  Files          17       17              
  Lines        2331     2338       +7     
==========================================
+ Hits         2222     2229       +7     
  Misses        109      109              
Files Coverage Δ
src/nd2/_util.py 98.66% <100.00%> (+0.07%) ⬆️
src/nd2/nd2file.py 97.38% <100.00%> (+0.02%) ⬆️
src/nd2/readers/_modern/modern_reader.py 93.28% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 6, 2023

CodSpeed Performance Report

Merging #181 will not alter performance

Comparing pub-api (67b1aa6) with main (788590b)

Summary

✅ 13 untouched benchmarks

@tlambert03 tlambert03 changed the title feat: add stuff to public api feat: add read_frame and loop_indices to public api Oct 6, 2023
@tlambert03 tlambert03 merged commit 82e7005 into main Oct 6, 2023
21 checks passed
@tlambert03 tlambert03 deleted the pub-api branch October 6, 2023 13:39
@tlambert03 tlambert03 added the enhancement New feature or request label Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant