Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: make binarylayer a dataclass #178

Merged
merged 4 commits into from
Sep 29, 2023
Merged

refactor: make binarylayer a dataclass #178

merged 4 commits into from
Sep 29, 2023

Conversation

tlambert03
Copy link
Owner

@tlambert03 tlambert03 commented Sep 29, 2023

This makes it easier to add a __getitem__ method to BinaryLayer that directly indexes the data attribute

@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

Merging #178 (82d4c15) into main (4df619e) will increase coverage by 0.18%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #178      +/-   ##
==========================================
+ Coverage   95.13%   95.32%   +0.18%     
==========================================
  Files          17       17              
  Lines        2325     2331       +6     
==========================================
+ Hits         2212     2222      +10     
+ Misses        113      109       -4     
Files Coverage Δ
src/nd2/_binary.py 95.94% <100.00%> (+6.24%) ⬆️
src/nd2/nd2file.py 97.35% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@codspeed-hq
Copy link

codspeed-hq bot commented Sep 29, 2023

CodSpeed Performance Report

Merging #178 will not alter performance

Comparing change-binary (82d4c15) with main (4df619e)

Summary

✅ 13 untouched benchmarks

@tlambert03 tlambert03 merged commit 32b8357 into main Sep 29, 2023
21 checks passed
@tlambert03 tlambert03 deleted the change-binary branch September 29, 2023 16:05
@tlambert03 tlambert03 added the enhancement New feature or request label Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant