Merge pull request sphinx-doc#9644 from xmo-odoo/fix-sourcename-broke…

…n-getattr Protect `sphinx.ext.autodoc.get_sourcename` against misbehaving `__getattr__`
tk0miya · Sep 17, 2021 · 62fd91b · 62fd91b
2 parents 506590d + 69af4d2
commit 62fd91b
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/sphinx/ext/autodoc/__init__.py b/sphinx/ext/autodoc/__init__.py
@@ -585,8 +585,8 @@ def process_doc(self, docstrings: List[List[str]]) -> Iterator[str]:
             yield from docstringlines
 
     def get_sourcename(self) -> str:
-        if (getattr(self.object, '__module__', None) and
-                getattr(self.object, '__qualname__', None)):
+        if (inspect.safe_getattr(self.object, '__module__', None) and
+                inspect.safe_getattr(self.object, '__qualname__', None)):
             # Get the correct location of docstring from self.object
             # to support inherited methods
             fullname = '%s.%s' % (self.object.__module__, self.object.__qualname__)