Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(payload_api, git_diff): Accessing correct property in payload and Replacing --quiet with --no-patch in git diff #1934

Merged
merged 2 commits into from
Feb 17, 2024
Merged

fix(payload_api, git_diff): Accessing correct property in payload and Replacing --quiet with --no-patch in git diff #1934

merged 2 commits into from
Feb 17, 2024

Commits on Feb 17, 2024

  1. Accessing Correct property, 

    since `payload.head` always been `undefined`
and after correcting property name it returns
`boolean` not a `string`
    @codesculpture @jackton1
    codesculpture authored and jackton1 committed Feb 17, 2024
    Configuration menu
    Copy the full SHA
    66b3b19 View commit details
    Browse the repository at this point in the history

  2. Using --no-patch instead of --quiet 

    Because --quiet would make the git diff
exits with 1 when it has differences, still
its not expected. Exit code none other than 0
is considered error.
    @codesculpture @jackton1
    codesculpture authored and jackton1 committed Feb 17, 2024
    Configuration menu
    Copy the full SHA
    d4aadb8 View commit details
    Browse the repository at this point in the history